This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: add interface and http client versions to version output#3125
Merged
achingbrain merged 2 commits intomasterfrom Jul 2, 2020
Merged
Conversation
Adds `interface-ipfs-core` and `ipfs-http-client` versions to the output of the `ipfs version` command, also the git commit id if it's available. Closes #2878
achingbrain
force-pushed
the
feat/add-interface-and-http-client-versions-to-version-command
branch
from
2f04471 to
1d780d6
Compare
lidel
suggested changes
Jun 25, 2020
Member
There was a problem hiding this comment.
LGTM, but needs:
- tests to guard against regressions (so people can rely on these keys to be present)
- updated docs in /docs/core-api/MISCELLANEOUS.md#ipfsversionoptions
achingbrain
deleted the
feat/add-interface-and-http-client-versions-to-version-command
branch
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Adds `interface-ipfs-core` and `ipfs-http-client` versions to the output of the `ipfs version` command, also the git commit id if it's available. Closes #2878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
interface-ipfs-coreandipfs-http-clientversions to the output of theipfs versioncommand, also the git commit id if it's available.Closes #2878